fix: add missing return after exitWithNoMatchingRequestError in CI mode #345
+5
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running tests in CI mode with no cached response, the proxy would crash with ERR_HTTP_HEADERS_SENT because exitWithNoMatchingRequestError() calls onError() (which writes headers), but then execution continued to super.performRequest() which also tries to write headers. This caused cascading test failures because the proxy process would die and subsequent tests couldn't communicate with it. This is why the 'sendAndWait throws on timeout' test is currently skipped in CI. With this fix, that test could potentially be enabled.
Now that the harness properly returns after exitWithNoMatchingRequestError, this test can run in CI without crashing the proxy.
Collaborator
|
@brunoborges thanks for the PR! there was an issue with one of the go tests but I pushed a fix, will merge as soon as CI is all green |
friggeri
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests in CI mode with no cached response, the proxy would crash with ERR_HTTP_HEADERS_SENT because exitWithNoMatchingRequestError() calls onError() (which writes headers), but then execution continued to super.performRequest() which also tries to write headers.
This caused cascading test failures because the proxy process would die and subsequent tests couldn't communicate with it.
This is why the 'sendAndWait throws on timeout' test is currently skipped in CI. With this fix, that test could potentially be enabled.
Fixes #344